Improve Consistency of Transform Primitives #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillKoehrsen
changed the title
WillKoehrsen
force-pushed
the
transform-stability
branch
from
c90e721
to
2a0bd7f
Compare
Codecov Report
@@ Coverage Diff @@
## master #236 +/- ##
==========================================
+ Coverage 93.63% 93.65% +0.01%
==========================================
Files 71 71
Lines 7671 7690 +19
==========================================
+ Hits 7183 7202 +19
Misses 488 488
Continue to review full report at Codecov.
|
|
Looks good. Merging |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the use of a
frozensetwhich is an unordered Python object, the order of commutative transform primitives that used multiple columns, such asAND, could change when running Deep Feature Synthesis in different Python sessions. This behavior did not affect the feature values because the primitives are commutative. It did change the feature definitions which made comparing different sets of feature definitions a challenge.The behavior is addressed by sorting the features used in commutative transform primitives alphabetically by name. For example, if the transform primitive
ANDis used with the features (columns)FLAG_AandFLAG_Bthe resulting feature will beAND(FLAG_A, FLAG_B).